Repository navigation
Conversation
Migrate the archived Cognee + Valkey cookbook (PR #15) to the current CONTRIBUTING.md structure: Ollama as the vendor-neutral default LLM and embedding provider (OpenAI/Bedrock as labeled alternatives), Valkey Bundle pinned to 9.1.0, generic multi-cloud production guidance, and a CI-friendly test suite that exercises the Valkey vector adapter directly with a deterministic stub embedder (no LLM required). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Anna Tao <annatao2004@gmail.com>
Collaborator
|
Closing this draft PR as part of a cookbook program cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the archived Cognee + Valkey cookbook (PR #15,
archive/main-pre-reorgbranch) to the current CONTRIBUTING.md cookbook structure.Upstream integration: topoteretes/cognee-community#46 (merged, released on PyPI as
cognee-community-vector-adapter-valkey==0.1.3).Changes from the archived version
<details>alternatives with AWS affiliation disclosed.valkey/valkey-bundle:latest→9.1.0.03-production.mdreworked from an ElastiCache-only deployment guide into generic production patterns (TLS, HNSW tuning, monitoring, error handling), with both AWS (ElastiCache/MemoryDB) and Google Cloud (Memorystore for Valkey) named as examples alongside generic managed-provider guidance.sample/docker-compose.ymland a CI-friendly test suite (test_valkey_adapter.py) — neither existed in the archive. The test suite exercises the Valkey vector adapter directly with a deterministic stub embedder, so it needs no LLM or Ollama to run in CI.sample/common.pyto share the Ollama/Cognee bootstrap config across the three sample scripts (previously would have been triplicated).meta.json— not part of the current cookbook structure.Validation
add → cognify → searchpipeline run end-to-end againstvalkey-bundle:9.1.0+ local Ollama (qwen2.5:7b+nomic-embed-text) — smaller models (llama3.2:1b/3b) were tried first and found unreliable for Cognee's structured-output requirements; documented in the cookbook.test_valkey_adapter.py(6 tests) passing in a clean-room venv againstrequirements.txtexactly as written, plus the actualdocker-compose.yml.markdownlint-cli2: 0 errors.ruff check: clean.## Step Nheadings in 02, missingHow It Works/Configuration Referencetables in 01, single-vendor cloud guidance in 03, duplicated config extracted tocommon.py, and an incorrectsafe_searchreturn type annotation.Pre-Submit Checklist
Known follow-up (not addressed in this PR)
cookbook-python.yml'sdorny/paths-filterfilter list doesn't include the workflow file path itself, even though the top-level trigger does — meaning a PR that only edits this CI file wouldn't exercise the jobs it configures. Left as-is since this file is the documented temporary-copy pattern pending PR #45's shared Python workflow, which is expected to supersede it.