Repository navigation
Conversation
Signed-off-by: Yang Zhao <zymy701@gmail.com>
Signed-off-by: Yang Zhao <zymy701@gmail.com>
Andriciuc
reviewed
Oct 9, 2026
Andriciuc
reviewed
Oct 9, 2026
Andriciuc
reviewed
Oct 9, 2026
madolson
reviewed
Oct 28, 2026
madolson
left a comment
madolson
left a comment
Member
There was a problem hiding this comment.
Outside of @Andriciuc I think this looks close. @yang-z-o can you clean up the few comments so we can merge this?
- Link ACL role commands throughout the roles section of the ACL topic - Document the null reply of ACL GETROLE for a missing role - Say ACL GETROLE rules use the ACL SETROLE format - Add the roles field to the ACL GETUSER example output Signed-off-by: Yang Zhao <zymy701@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document ACL roles, added in valkey-io/valkey#3967, closes #495.
ACL SETROLE,ACL DELROLE,ACL GETROLE,ACL ROLESACL SETUSER/GETUSER/LIST/USERSand the ACL topic for roles