Skip to content

fix(skill-market): pin accepted addresses for mixed DNS - #1437

Merged
vastsa merged 2 commits into
mainfrom
fix/skill-market-ula-dns
Oct 6, 2026
Merged

vastsa merged 2 commits into
mainfrom
fix/skill-market-ula-dns

Conversation

@vastsa

@vastsa vastsa commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Pin a vetted address for direct requests when DNS returns both an acceptable address and a rejected ULA address.
  • Prefer public addresses for third-party content; use the benchmark fake-IP only under the existing policy opt-in.
  • Keep ULA-only answers blocked and validate each redirect hop independently.

Validation

  • pnpm build:js
  • pnpm --filter @pi-desktop/desktop typecheck
  • 51 related Node tests passed.
  • Skill Market E2E: 5/5 passed.
  • pnpm check:pr-base

Mixed DNS responses can include a usable address and a synthetic ULA. Pinning the vetted address prevents the transport from selecting the rejected result while keeping ULA-only answers blocked.

Revalidate and pin every redirect hop so the direct transport keeps the existing public-network boundary.
Copilot AI balanced review requested due to automatic review settings October 6, 2026 15:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Keep the localized decisions log aligned with the new D648 source row and date so locale structure validation continues to pass.
@vastsa
vastsa merged commit 048e4d3 into main Oct 6, 2026
5 checks passed
@vastsa
vastsa deleted the fix/skill-market-ula-dns branch October 6, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants