Repository navigation
fix(renderer): page large tool output - #1439
Merged
Merged
Conversation
Bound expanded tool output to one UTF-16-safe preview page so huge results cannot render or highlight as a single block. Record confirmed shutdown before awaited teardown so forced quits retain the lifecycle boundary.
Lucide's exported prop alias does not include the full SVG attribute surface used by the app. Intersect it with React SVG props so the wrapper type matches the attributes it already forwards.
Keep the translated plugin marketplace page in sync with the canonical ADR path so the documentation site can build and validate all routes.
Update transcript source contracts to match the bounded preview component and its running-state follow behavior. This keeps the renderer regression suite aligned with the new presentation path.
Incorporate the latest main before integration validation. The incoming settings and spec updates share the E2E plan, and its rendering scenario remains intact alongside the large tool-output coverage.
The plugin subprocess can start later than a fixed setImmediate polling loop allows under the full test suite. Wait on the notification callback directly and retain a bounded test timeout.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app shutdownlog synchronously before awaited teardown.Validation
origin/mainis an ancestor of this branch.