core: supplemental data is encoded as JSON#390
Open
MariusBgm wants to merge 1 commit into
Open
Conversation
Signed-off-by: Marius Börschig <Marius.Boerschig@vector.com>
VDanielEdwards
self-requested a review
July 15, 2026 14:17
VDanielEdwards
approved these changes
Jul 15, 2026
VDanielEdwards
left a comment
VDanielEdwards
left a comment
Member
There was a problem hiding this comment.
LGTM 👍 Tested it manually against 5.0.6 (which uses the 'old' supplemental data serialization).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supplemental data was always intended to be encoded as JSON.
This should be backwards compatible, as we use yaml parser to parse JSON and yaml.