Test/website redirect - #2349
Merged
Merged
Conversation
lrm25
force-pushed
the
test/website_redirect
branch
2 times, most recently
from
September 8, 2026 13:18
7302115 to
a51ff2a
Compare
anodelman
requested changes
Sep 8, 2026
lrm25
force-pushed
the
test/website_redirect
branch
8 times, most recently
from
September 10, 2026 17:56
d6c4e8b to
f3f1312
Compare
anodelman
requested changes
Sep 10, 2026
lrm25
force-pushed
the
test/website_redirect
branch
3 times, most recently
from
September 11, 2026 15:25
d52fb34 to
f384991
Compare
anodelman
requested changes
Sep 11, 2026
| log 2 "error uploading part $i: $response" | ||
| return 1 | ||
| fi | ||
| quoted_etag="$response" |
Contributor
There was a problem hiding this comment.
i think that you want
quoted_etag="\"$response\""
Contributor
Author
There was a problem hiding this comment.
I double-checked, and it's returned double-quoted from S3, and therefore versitygw to match, e.g.:
# {
# "ServerSideEncryption": "AES256",
# "CopyPartResult": {
# "ETag": "\"34018cfe8a897549bdd8b3028158520f\"",
# "LastModified": "2026-09-11T21:51:11+00:00"
# }
# }
It's confusing, but the technical value that S3 returns is already quoted. Quoting it again results in an error. But I added a comment to explain this better in the code.
| log 2 "error uploading part $i: '$response'" | ||
| return 1 | ||
| fi | ||
| quoted_etag="$response" |
Contributor
There was a problem hiding this comment.
same here
quoted_etag="\"$response\""
| log 2 "error with multipart upload" | ||
| return 1 | ||
| fi | ||
| if ! get_object "s3api" "$bucket" "${key}-copy" "${large_file}-copy"; then |
Contributor
There was a problem hiding this comment.
Do you want to get this to the TEST_FILE_FOLDER so that it gets cleaned up?
Contributor
Author
There was a problem hiding this comment.
Checked, and the large_file param itself is passed in as a full path including this folder, but specified that it's the full path at the top of the function now.
lrm25
force-pushed
the
test/website_redirect
branch
2 times, most recently
from
September 11, 2026 23:26
211a9f5 to
a4fabe3
Compare
lrm25
force-pushed
the
test/website_redirect
branch
from
September 13, 2026 14:36
a4fabe3 to
642b65f
Compare
anodelman
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.