Skip to content

fix: object verson mtime #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benmcclelland merged 2 commits into from
Sep 15, 2026
Merged

fix: object verson mtime #2383

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ab0db4
fix: object verson mtime
JoshPigott Sep 11, 2026
11a517c
fix: avoid nil-pointer panic in mtime
JoshPigott Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions backend/posix/posix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1166,12 +1166,23 @@ func (p *Posix) createObjVersion(bucket, key string, size int64, acc auth.Accoun
}
defer f.cleanup()

originalMTime := time.Now()
if srcInfo, err := sf.Stat(); err == nil {
originalMTime = srcInfo.ModTime()
}

// Prioritize copy_file_range for internal file-to-file version copies.
_, err = io.Copy(f.File(), sf)
if err != nil {
return versionPath, err
}

// Restore original mtime after copy
err = os.Chtimes(f.File().Name(), time.Now(), originalMTime)
if err != nil {
return versionPath, err
}

versionPath = filepath.Join(versionBucketPath, versioningKey)

err = os.MkdirAll(filepath.Join(versionBucketPath, genObjVersionKey(key)), p.newDirPerm)
Expand Down
Loading