Update obstacle docs for open (uncapped) cylinder geometry - #5283
Update obstacle docs for open (uncapped) cylinder geometry#5283Shannon Bradshaw (shannonbradshaw) wants to merge 3 commits into
Conversation
rdk#6383 added a `capped` field to GeometryConfig. When set to false, a cylinder becomes an open tube with no end caps, letting the planner route through the hollow interior. This is useful for modeling round containers like pots, pans, and tubes that a robot needs to reach into. - Update geometry types table in overview.md with the new `capped` field - Add "Round containers (open cylinder)" section to configure page - Clarify existing caveats apply specifically to open boxes
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This change is not in the current RDK release, so we should hold publication until at least the week of 8/31. There also seems to be some current work going on with cylinder geometry generally, so let's take a close look at this at that time and confirm with engineering if necessary. |
|
A few things came up while reviewing that I'd like your take on: 1. Structural placement: the new "Round containers (open cylinder)" subsection lives under "Containers and work-cell boundaries," but that section is specifically about 2. Missing the "which component" step: the current snippet is a bare Separately, and not blocking this PR: |
Move "Round containers (open cylinder)" out of the obstacle-open-box section into its own peer section with full component walkthroughs (both erh:vmodutils:obstacle and rdk:builtin:fake patterns). Add open cylinder to the pattern summary table. Restore original caveats wording. Addresses jeremyrose-viam review feedback on structural placement and missing component walkthrough.
|
Agreed on the hold until the RDK release ships — no rush on merging. Pushed a restructure addressing both points:
Happy to adjust further when you review with engineering the week of 8/31. Generated by Claude Code |
|
This RDK change is shipped in v1.6.0, but it appears there's still quite a bit of churn with cylinders currently. viamrobotics/rdk#6388 and viamrobotics/api#894 are still in draft, and in the meantime there seem to be issues with cylinder behavior. Should we consider holding this doc update until cylinder behavior is consistent? |
|
Makes sense — holding until the cylinder work stabilizes. I'll keep this PR open and check back once rdk#6388 and api#894 land to see if the Generated by Claude Code |

RDK #6383 added a
cappedfield toGeometryConfig. When set tofalse, a cylinder becomes an open tube with no end caps, leaving the hollow interior as free space so the motion planner can route through it. This models round containers (pots, pans, tubes) that a robot needs to reach into, replacing the previous workaround of approximating a round wall with multiple boxes.Source changes
cappedfield onGeometryConfig)Docs changes
docs/motion-planning/obstacles/overview.md: Updated the geometry types table to include the optionalcappedfield on cylinder, with a description of what it doesdocs/motion-planning/obstacles/configure-workspace-obstacles.md: Added a "Round containers (open cylinder)" subsection under "Containers and work-cell boundaries" with a JSON example; clarified existing caveats apply specifically to the open-box patternHow I found these
config-xref.md(GeometryConfig),flows.md(motion planning)Generated by daily docs change agent
Generated by Claude Code