Skip to content

RSDK-14456: Add manual mode arm API - #705

Merged
lia (lia-viam) merged 2 commits into
mainfrom
RSDK-14456-add-manual-mode-arm-api
Sep 3, 2026
Merged

lia (lia-viam) merged 2 commits into
mainfrom
RSDK-14456-add-manual-mode-arm-api

Conversation

@npmenard

@npmenard Nicolas Menard (npmenard) commented Sep 2, 2026 •

Copy link
Copy Markdown
Member

Adds get_properties, set_manual_mode(manual_mode, enabled_for), and get_manual_mode to the C++ Arm class.

@npmenard
Nicolas Menard (npmenard) marked this pull request as ready for review September 2, 2026 12:55
@npmenard
Nicolas Menard (npmenard) requested a review from a team as a code owner September 2, 2026 12:55
@npmenard
Nicolas Menard (npmenard) requested review from lia (lia-viam) and martha-johnston and removed request for a team September 2, 2026 12:55

@lia-viam lia (lia-viam) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks basically fine, although we obviously can't merge until the build is passing. having the new proto files committed in the PR branch seems odd though--have these changes not yet landed in api yet? they should have been picked up by the automated protos update job, hence having no need to make the updates within this PR once the automated PR lands

@npmenard
Nicolas Menard (npmenard) force-pushed the RSDK-14456-add-manual-mode-arm-api branch from b4d3853 to ffb9450 Compare September 3, 2026 19:06
@npmenard

Copy link
Copy Markdown
Member Author

this looks basically fine, although we obviously can't merge until the build is passing. having the new proto files committed in the PR branch seems odd though--have these changes not yet landed in api yet? they should have been picked up by the automated protos update job, hence having no need to make the updates within this PR once the automated PR lands

Yes sorry I should have said something about it in the description. Basically I just wanted to make sure the code as it was would pass the CI but ultimately rebase once the proto changes were merged in the sdk

@lia-viam
lia (lia-viam) merged commit 8f56f86 into main Sep 3, 2026
5 checks passed
@lia-viam
lia (lia-viam) deleted the RSDK-14456-add-manual-mode-arm-api branch September 3, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants