Repository navigation
Conversation
Closes the external-resolve gap from the README deferred-features register, building on the evaluateAsync() suspend-and-replay path: - New ReferenceResolver option: resolve() still handles contained (#id) and Bundle-internal references synchronously itself, and hands anything else — absolute urls, relative Type/id references outside the Bundle — to the caller's resolver, one awaited call per distinct reference. - Fragment (#id) misses never consult the resolver: fragments are internal by definition. - A resolver answer of undefined (or any non-object) yields empty, like every other unresolvable reference; resolver rejections propagate. - Without a resolver the behavior is unchanged: external references quietly resolve to nothing. With one, a sync evaluate() that actually hits an external reference fails with a pointer to evaluateAsync(). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The SDC assessment reproduces the two remote-resolution gaps this PR addresses: relative #121 fixes the separate local scope gap mentioned in this PR description. It resolves I am updating this PR after #3 and will run the thermo-nuclear review loop before publishing the replacement commits. The remote fallback should compose with the new local resolver, preserve the resolved resource's scope for subsequent navigation, and keep fragment misses local. Please retain the current analyzer's target-profile typing during that update. Public focus/context ergonomics remain tracked separately in #119. The broader assessment scripts and copied upstream fixtures stay local. |
This branch has not been deployed
1 participant
Adds a host resolver so expressions such as
subject.resolve().name.givencan read an external Patient throughoptions.resolver, while preserving contained and Bundle resolution.Targets
feat/terminology(#3), updated to7b65822with current main (f66e445). Merge #3 first.resolve()tries the originating resource and Bundle first. Unresolved external references reach(reference: string) => Promise<unknown>unchanged; fragment misses stay local. The host owns server-base handling, authentication, and transport. Local results retain their indexed ancestry forpathname()and later resolution; returned external resources own subsequent contained navigation.The callback runs at most once per distinct reference per async evaluation through #3's cache/replay mechanism. Non-resource answers produce empty results, and callback rejections propagate. Without a resolver, external misses remain empty; synchronous calls that need a configured resolver direct callers to
evaluateAsync().Validation on
226a3c0: 8,840 tests passed, 1,430 existing skips, across 69 files. Typecheck, lint, static FHIRPath checks, generated inference, type budgets, coverage, build, installed-package checks, and demo typecheck/tests/build all pass. Coverage: 99.41% statements, 96.85% branches, 99.81% functions, 99.40% lines. No thresholds or budgets changed.The local Smart Forms comparison passes 76/76 extraction, 28/28 renderer, and 9/9 service/scoring/resolution probes. Population passes 208/209 unchanged assertions plus the separate full-response date assertion; the mismatch preserves four valid dates that fhirpath.js omits. All 29 local SDC tests and 33 focused conformance probes pass. The adapter and broad assessment tools remain local; #119 and #120 remain separate follow-ups.
Independent thermo-nuclear review approved
226a3c0with no blockers, including checks for indexed ancestry, multiple remote/contained hops, negative caching, and exclusion of external resources from localpathname()results.