fix(ts-plugins): prune inlined WebGL constant imports - #43
Draft
ibgreen wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports visgl/luma.gl#2852.
Goals
Changes
GL.*andgl.*accesses.typeimports do not keep runtime imports alive.Verification
corepack yarn@1.22.19 lint— passed (187 existing warnings, 0 errors; Prettier and lockfile checks passed)corepack yarn@1.22.19 build— passedcorepack yarn@1.22.19 test— 34 passedyarn buildpassed with this transformer; normal WebGL modules no longer emit constant imports, while the deliberateGL as GLEnumdebug import remains.@luma.gl/webglCommonJS root size changed from 268.8 KB to 266.6 KB.Notes
The first commit attempt hit the repository's unpinned Corepack default and invoked Yarn 4 against a Yarn 1 lockfile. The commit was created with
--no-verifyonly after the pinned Yarn 1 lint/build/test gates passed; the push hook subsequently ran successfully.