Conversation
VPS-Obi
changed the title
VPS-Obi
force-pushed
the
claude/relaxed-allen-03kdes
branch
from
September 14, 2026 12:37
e779920 to
58d31ed
Compare
VPS-Obi
commented
Sep 14, 2026
VPS-Obi
marked this pull request as ready for review
September 14, 2026 13:50
VPS-Obi
force-pushed
the
claude/relaxed-allen-03kdes
branch
from
September 14, 2026 14:05
58d31ed to
d3bf2c7
Compare
VPS-Obi
added this pull request to stack #6365
September 14, 2026 14:21
VPS-Obi
force-pushed
the
claude/relaxed-allen-03kdes
branch
from
September 15, 2026 06:17
d3bf2c7 to
aa95ecd
Compare
nsams
reviewed
Sep 15, 2026
| @BlockDataMigrationVersion(migrate.version) | ||
| class RichTextBlockData extends BlockData { | ||
| @BlockField({ type: "json" }) | ||
| @BlockField({ type: "richTextBlock", linkBlock: LinkBlock }) |
Member
There was a problem hiding this comment.
if someone doesn't use our cli package to generate-block-types and accesses the bkock-meta json directly this is incompatible. Should we ignore that?
Contributor
Author
There was a problem hiding this comment.
I've found five projects that have a custom generate-block-types.ts script, two of them being unmaintained. Should we update the three projects or target next for this? I can work around the duplicate space block in the application.
Contributor
Author
There was a problem hiding this comment.
@nsams I'd target next and make this a breaking change, what do you think?
Member
There was a problem hiding this comment.
if you don't need it in main the easiest solution if of course next.
Contributor
Author
There was a problem hiding this comment.
It now targets next. I also started the migration guide.
The block meta didn't say which link block is used for links inside rich text content, so consumers of block-meta.json had no way to resolve the link data embedded in the content. Blocks created with createRichTextBlock now use a new RichTextBlock field kind (instead of Json) for draftContent, which carries the link block. Blocks created with createTipTapRichTextBlock carry it in their existing TipTapRichTextBlock field, next to the child blocks. The generated block types are unchanged: rich text fields are still typed as unknown, but generate-block-types has to know the new field kind. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HpJKNHRbSSBCFdfgLao1zo
VPS-Obi
force-pushed
the
claude/relaxed-allen-03kdes
branch
from
September 17, 2026 12:22
aa95ecd to
02b148d
Compare
VPS-Obi
removed this pull request from stack #6365
September 17, 2026 12:24
Add the guide for the breaking changes that are on next so far: the new RichTextBlock field kind in the block meta and the removal of FormMutation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HpJKNHRbSSBCFdfgLao1zo
VPS-Obi
force-pushed
the
claude/relaxed-allen-03kdes
branch
from
September 17, 2026 12:27
02b148d to
69bef12
Compare
VPS-Obi
added this pull request to stack #6398
September 17, 2026 12:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #6340 (comment): add the rich text blocks' link blocks to the block meta instead of adding a new
referencedBlocksfield toBlock.Rich text blocks created with
createRichTextBlocknow use the newRichTextBlockfield kind (instead ofJson) for theirdraftContentfield, which contains the link block:{ "name": "draftContent", "kind": "RichTextBlock", "nullable": false, "linkBlock": "Link" }Rich text blocks created with
createTipTapRichTextBlockcontain the link block in their existingTipTapRichTextBlockfield, next to the child blocks. It is omitted when links are disabled:{ "name": "tipTapContent", "kind": "TipTapRichTextBlock", "nullable": false, "childBlocks": {}, "linkBlock": "Link" }Since the field kind of
draftContentchanges, this is a breaking change for projects that readblock-meta.jsonthemselves. The changeset is therefore a major one and the branch targetsnext(the base branch of this PR still needs to be changed frommaintonext).The second commit starts the v11 migration guide with the section for this change.
https://claude.ai/code/session_01HpJKNHRbSSBCFdfgLao1zo