Skip to content

fix(run): restore task configuration from Vite plugin hooks - #3232

Closed
liangmiQwQ wants to merge 8 commits into
voidzero-dev:mainfrom
liangmiQwQ:liang/codex/restore-plugin-run-config
Closed

fix(run): restore task configuration from Vite plugin hooks#3232
liangmiQwQ wants to merge 8 commits into
voidzero-dev:mainfrom
liangmiQwQ:liang/codex/restore-plugin-run-config

Conversation

@liangmiQwQ

@liangmiQwQ liangmiQwQ commented Oct 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Revert #1214
Bring back #1213

@liangmiQwQ liangmiQwQ added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests test: sfw labels Oct 25, 2026
@liangmiQwQ liangmiQwQ mentioned this pull request Oct 26, 2026
Merged
@liangmiQwQ

liangmiQwQ commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator Author

Tiptap CI is fixed in ueberdosis/tiptap@3aab4cc

See #3242

@liangmiQwQ

liangmiQwQ commented Nov 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

CI failing was fixed in voidzero-dev/vite-task#944

@liangmiQwQ
liangmiQwQ marked this pull request as ready for review November 13, 2026 11:31
@liangmiQwQ

liangmiQwQ commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator Author

@fengmk2 do you think this pr still worth merging? For me, the experiment of Vite+ plugin is already hold off.

@fengmk2

fengmk2 commented Nov 13, 2026

Copy link
Copy Markdown
Member

I don't quite remember what problem this fix was meant to solve anymore; I need to take some time to look at it again.

@fengmk2

fengmk2 commented Nov 13, 2026

Copy link
Copy Markdown
Member

Let’s hold off on this for now. We don’t plan to support modifying vp run configuration through Vite plugin hooks yet, so we’ll keep the current static config behavior. Thanks for working on this!

@fengmk2 fengmk2 closed this Nov 13, 2026
@fengmk2

fengmk2 commented Nov 13, 2026

Copy link
Copy Markdown
Member

cc @wan9chi

@liangmiQwQ

liangmiQwQ commented Nov 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Let’s hold off on this for now. We don’t plan to support modifying vp run configuration through Vite plugin hooks yet, so we’ll keep the current static config behavior. Thanks for working on this!

@fengmk2 By the way, do you think we should disable config hook's behavior in future version, to ensure dynamic config and static config share behavior consistency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test: create-e2e Run `vp create` e2e tests test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: sfw

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liangmiQwQ @fengmk2