[btea]

Description

close #1168 cc @liangmiQwQ

[haoqunjiang]

(This comment is posted by Claude Code on my behalf)

Thanks for working on this! The mechanics are a good base: no vp migrate at scaffold time, the placement in the experimental list, and the vite alias (which matches Vite+'s own migration rules) all look right to me. There are a few design and correctness points I'd like to see addressed before merging, though.

Design

1. Gate the prompt. The experimental entry should only be shown when the global vp binary is found (on PATH, or under VP_HOME / ~/.vite-plus/bin). Users who don't have Vite+ installed should see no change in the prompts. The explicit --vite-plus flag can keep working for everyone.

2. Separate "launched by Vite+" from the feature flag. --vite-plus is in FEATURE_FLAGS, so passing it skips all the interactive prompts. That means vp create vue can't simply pass this flag, or users would get a default project without being asked anything. We need a signal that turns Vite+ on while the other prompts still run, e.g. an environment variable set by vp create. In that case the Vite+ entry itself doesn't need to be shown.

3. Make lint and format implied under Vite+. Oxlint and Oxfmt ship inside vite-plus, so vp lint and vp fmt scripts and their config should always be generated. Currently vp lint only appears if ESLint was selected, and vp fmt only if Oxfmt was.

4. Drop ESLint and Prettier on this path. vp lint is Oxlint-only and vp fmt is Oxfmt, so the ESLint and Prettier templates should be skipped when Vite+ is on. (This also avoids the unmet oxlint peer of eslint-plugin-oxlint, and having to keep its version in lockstep with the Oxlint version bundled in vite-plus.) In the prompt path, print a short note that they were replaced; for conflicting flags such as --vite-plus --eslint, warn and ignore the conflicting one. When launched by vp create vue, the Linter / Prettier / Oxfmt entries can be hidden altogether.

5. Move the config into vite.config. Vite+'s docs recommend against vitest.config.*, .oxlintrc.json and .oxfmtrc.json. The generated project should use the test, lint and fmt blocks in vite.config, with defineConfig imported from vite-plus.

Correctness

6. Peer ranges outside pnpm. @vitejs/plugin-vue expects vite@^5 || ^6 || ^7 || ^8, while the core alias is versioned 1.x. Only pnpm gets a peerDependencyRules relaxation here. Could you confirm that installation is clean on npm, yarn and bun as well?

Non-blocking

7. Version of the core alias. The alias version lives in a TypeScript constant that Renovate won't see, so it will go stale silently. It's not a big problem in practice: both ranges are carets on packages released in lockstep, and vp create re-pins them anyway when the project is created through Vite+. Still, it would be nice to declare the aliased vite entry in the template's package.json next to vite-plus and read the spec from the manifest in applyOverrides, so that Renovate keeps both up to date.

[haoqunjiang]

@liangmiQwQ

I found a few issues during the review process, so it would be great if the Vite+ team could confirm a couple of things:

1. • Separate "launched by Vite+" from the feature flag. --vite-plus is in FEATURE_FLAGS, so passing it skips all the interactive prompts. That means vp create vue can't simply pass this flag, or users would get a default project without being asked anything. We need a signal that turns Vite+ on while the other prompts still run, e.g. an environment variable set by vp create. In that case the Vite+ entry itself doesn't need to be shown.

Is there currently such an environment variable available in Vite+?

2. Regarding vp migrate, I noticed that during the initial project creation, since create-vue also generates vscode settings, I'm prompted to decide what to do with these files, with skip being the default option. I don't think it's the best onboarding experience for new users. IMO we should skip the prompt and just merge the templates if vp migrate is called from vp create:

[liangmiQwQ]

1. Not for now, and that becomes a problem. I agree with you so Vite+ team is finding a way to add env variables for this case.
2. I'm working on a change, that let vp create skips the migration steps if the create-xxx cli already generates a Vite+ project.

Let's continue this PR after these upstream changes.

(Really apologize for my late reply, I somehow missed the notification 🙇🙇)

[liangmiQwQ]

Update:

• The released Vite+ 1.6.0 introduces a VP_USER_AGENT, to show if the process is launched by Vite+ (feat(cli): advertise VP_USER_AGENT to child processes voidzero-dev/vite-plus#1958)
• In the next version of Vite+, the VSCode configure and other prompts workflow will be simplified, and some duplicated questions will be skipped. (feat(create): skip migration for templates that already use Vite+ voidzero-dev/vite-plus#3424, feat(create): ask setup questions after the create-xxx CLI runs voidzero-dev/vite-plus#3435)

[btea]

Thanks for reviewing. I've updated it.