Skip to content

Always four videos, drag over replaces video below - #209

Open
whyboris wants to merge 2 commits into
vzhd1701:masterfrom
whyboris:four-by-four
Open

whyboris wants to merge 2 commits into
vzhd1701:masterfrom
whyboris:four-by-four

Conversation

@whyboris

@whyboris whyboris commented Apr 2, 2024 •

Copy link
Copy Markdown

🥳 seems to work well 😎

update: 😅 whoops - I meant to create this PR on my fork, not against master in your codebase :trollface:

Please close this PR -- it was meant for my personal build of the application; changes in this PR replace previous functionality 🪓

@o-data

o-data commented Apr 17, 2025

Copy link
Copy Markdown

I think it a great feature to have even in the Master.

@whyboris

Copy link
Copy Markdown
Author

😊 lovely to see my PR still open after all these years -- perhaps it's a sign of interest to merge some day? 👍

👍 I wouldn't mind seeing this merged in after adding an option in settings that controls behavior 😊

Years later I still find the four-video-maximum functionality most-comfortable for my use case 🙃

I'm not familiar with Qt5 but can can update this PR with an option in the setting that toggles the behavior if you point me to a good location (in code) for the toggle 🤝

@vzhd1701

Copy link
Copy Markdown
Owner

Yes, I like your idea. I am planning on adding fixed grid mode where you can set fixed size to whatever you like. I will also add option to replace videos on drag-n-drop instead of adding them, maybe with like shift+drag and option to select default behavior.

@vzhd1701

vzhd1701 commented Sep 1, 2026 •

Copy link
Copy Markdown
Owner

Fixed grid mode is in master now, please check it out and tell me how it works for you. I also added configurable options for replacing videos during drag-n-drop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants