fix: grant chart release caller artifact access - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub rejected the tag workflow at compile time because the reusable chart publisher requests
actions: readwhile its caller explicitly reduced that permission to none. Grant the caller read-only artifact access and cover the caller/callee contract in the release workflow fixture.No release job started and no registry/chart/release mutation occurred in failed run 34369483030.
Validation:
make release-workflow-testactionlintNote
Low Risk
CI-only permission wiring for the release pipeline; no runtime operator or chart behavior changes.
Overview
Tag releases were failing before any jobs ran because the reusable
chart-release.ymlworkflow requiresactions: read(for artifacts), while thechart-publicationcaller job did not grant that permission鈥擥itHub rejects that permission mismatch at workflow compile time.This change adds
actions: readto thechart-publicationjob inrelease.yml, alongside the existingcontents: readandid-token: write, so the caller satisfies the reusable workflow contract.The release workflow fixture in
.test/release-workflow.shnow asserts thatchart-publicationincludesactions: read, locking in the caller/callee expectation.Reviewed by Cursor Bugbot for commit 10f2286. Configure here.