Repository navigation
fix: keep barrels outside the target directory - #4
Open
everton-dgn wants to merge 1 commit into
Open
everton-dgn wants to merge 1 commit into
everton-dgn wants to merge 1 commit into
Conversation
Running with `cwd: "packages/app"` can delete a barrel in `packages/app-shared`. The current prefix check treats that sibling as part of app, even though its other consumers were never scanned. Keep the existing path spelling requirement and add path-relative containment in both classification passes. A write-mode regression verifies that the sibling barrel and its consumer survive while an eligible barrel inside app is still removed. Unit cases cover root directories, trailing separators and Windows path forms. Validation: 188 tests, build, typecheck, lint and formatting passed. Build/tests and installed-check also passed on the CI's Node 24. Windows paths were tested with path.win32; no Windows runtime was used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running with
cwd: "packages/app"can delete a barrel inpackages/app-shared. The current prefix check treats that sibling as part of app, even though its other consumers were never scanned.Keep the existing path spelling requirement and add path-relative containment in both classification passes. A write-mode regression verifies that the sibling barrel and its consumer survive while an eligible barrel inside app is still removed. Unit cases cover root directories, trailing separators and Windows path forms.
Validation: 188 tests, build, typecheck, lint and formatting passed. Build/tests and installed-check also passed on the CI's Node 24. Windows paths were tested with path.win32; no Windows runtime was used.