Repository navigation
fix: preserve statements between organized imports - #5
Open
everton-dgn wants to merge 1 commit into
Open
everton-dgn wants to merge 1 commit into
everton-dgn wants to merge 1 commit into
Conversation
With organizeImports enabled, merging duplicate imports currently removes every statement between the first and last import. An exported value in that interval disappears, leaving its consumers broken. Limit merging to import sequences with no intervening statements, and replace only the import declarations. This preserves statement boundaries in code without semicolons. Groups with TypeScript suppression directives stay intact so their comments keep the same targets. Regressions exercise the public write API and run the resulting modules, checking exports and effect order. A compiler check also verifies that @ts-expect-error directives remain used. All 194 tests, build, lint and formatting passed on Node 24; installed-check passed with the unchanged dependency set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With organizeImports enabled, merging duplicate imports currently removes every statement between the first and last import. An exported value in that interval disappears, leaving its consumers broken.
Limit merging to import sequences with no intervening statements, and replace only the import declarations. This preserves statement boundaries in code without semicolons. Groups with TypeScript suppression directives stay intact so their comments keep the same targets.
Regressions exercise the public write API and run the resulting modules, checking exports and effect order. A compiler check also verifies that @ts-expect-error directives remain used. All 194 tests, build, lint and formatting passed on Node 24; installed-check passed with the unchanged dependency set.