Repository navigation
fix: isolate exported-name caches between runs - #7
Open
everton-dgn wants to merge 1 commit into
Open
everton-dgn wants to merge 1 commit into
everton-dgn wants to merge 1 commit into
Conversation
Calling unbarrelify again after changing a source file can reuse its old exported names. A dry-run followed by a write can then point an import at a file that no longer exports that name. Keep the export cache in the context of each run. Barrels within one run still share it, while separate and overlapping calls use independent caches. The regressions exercise both discovery and explicit-barrel modes, then execute the rewritten consumers. All 185 tests, build, lint, formatting and installed-check passed on Node 24. The four new cases fail against the base.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling unbarrelify again after changing a source file can reuse its old exported names. A dry-run followed by a write can then point an import at a file that no longer exports that name.
Keep the export cache in the context of each run. Barrels within one run still share it, while separate and overlapping calls use independent caches. The regressions exercise both discovery and explicit-barrel modes, then execute the rewritten consumers.
All 185 tests, build, lint, formatting and installed-check passed on Node 24. The four new cases fail against the base.