Repository navigation
fix: preserve selected barrels with remaining consumers - #9
Open
everton-dgn wants to merge 1 commit into
Open
everton-dgn wants to merge 1 commit into
everton-dgn wants to merge 1 commit into
Conversation
With --only, consumer registration was skipped. A selected barrel could be deleted while a dynamic import, namespace import or non-TypeScript file still needed it. Track consumers for explicitly selected barrels, including imports inside files forced to be barrels. Register the full selection before checking its relationships so selection order does not affect preservation, and retain the correct reason for star re-exports. Supported JavaScript namespace consumers now report the same preservation reason as TypeScript consumers. The 197-test suite passed on Node 24. All 16 focused cases passed on Node 24 and compiled Node 20, including before/after execution, selection-order controls and dry-run/check behavior. Build, typecheck, lint and formatting checks passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With --only, consumer registration was skipped. A selected barrel could be deleted while a dynamic import, namespace import or non-TypeScript file still needed it.
Track consumers for explicitly selected barrels, including imports inside files forced to be barrels. Register the full selection before checking its relationships so selection order does not affect preservation, and retain the correct reason for star re-exports. Supported JavaScript namespace consumers now report the same preservation reason as TypeScript consumers.
The 197-test suite passed on Node 24. All 16 focused cases passed on Node 24 and compiled Node 20, including before/after execution, selection-order controls and dry-run/check behavior. Build, typecheck, lint and formatting checks passed.