Skip to content

fix(build): rpm-rewrap hands the build container's files back to the caller #4065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bpamiri merged 1 commit into from
Oct 2, 2026
Merged

fix(build): rpm-rewrap hands the build container's files back to the caller #4065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tools/distribution-drafts/linux-packages/rpm-rewrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ cp "${IN_ABS}" "${WORK}/in.rpm"
cat > "${WORK}/rewrap-inside.sh" <<'INSIDE_EOF'
#!/bin/bash
set -euo pipefail
# The container runs as root (it installs rpm-build), so everything it writes to
# the bind mount is root-owned on a Linux host. Hand it back to the caller on any
# exit, or the caller's cleanup of WORK fails with Permission denied.
trap 'chown -R "${HOST_UID}:${HOST_GID}" /w' EXIT
dnf -q -y install rpm-build cpio >/dev/null
IN=/w/in.rpm
q() { rpm -qp --qf "$1" "${IN}"; }
Expand Down Expand Up @@ -125,7 +129,7 @@ cp "${OUTRPM}" /w/out.rpm
echo "rpm-rewrap: rebuilt $(basename "${OUTRPM}") (archive ${ARCHIVE} bytes = stream)"
INSIDE_EOF

docker run --rm -v "${WORK}:/w" "${BUILD_IMAGE}" bash /w/rewrap-inside.sh
docker run --rm -e HOST_UID="$(id -u)" -e HOST_GID="$(id -g)" -v "${WORK}:/w" "${BUILD_IMAGE}" bash /w/rewrap-inside.sh

# rpm2cpio | cpio -t must exit 0 on each target rpm version.
for image in ${CHECK_IMAGES}; do
Expand Down
Loading