Repository navigation
ci: retry the release builds' and compat matrix's external downloads - #4307
Conversation
The snapshot build's Linux packaging fetched the LuCLI jar and the SQLite JDBC jar with a bare curl, so one HTTP 429 from GitHub failed the whole publish. Both now retry like the job's nfpm fetch (--retry 3 --retry-delay 2 --retry-all-errors), as does the release-candidate workflow's CommandBox GPG key download, whose -fsSl also becomes -fsSL (lowercase l is --list-only, not follow redirects). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
compat-pr.yml and compat-matrix.yml fetched ojdbc10.jar with a bare wget, and Oracle gates the matrix, so one rate-limited response turned a whole leg red. Both now use curl with the same retry flags as the release builds' downloads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
rev1-r3 review @ d286ad9: APPROVE
Nit, no change needed: the GPG key goes to stdout and is piped into |
|
rev1-r3 review @ c92eaca: code APPROVE (final sign-off after matrix run 37236762366) Delta Remaining gate: on run 37236762366, the "Download ojdbc10 for Adobe engines" step succeeds on every Adobe job (the step only runs for |
With --retry-all-errors on a piped download, a transfer retried mid-body could hand gpg a partial or duplicated stream. The key now goes to $RUNNER_TEMP first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
rev1-r3 review @ 3648649: code APPROVE (final sign-off after matrix run 37236762366 on Delta Nit, no change needed: |
|
rev1-r3 review @ 3648649: APPROVE (final) Matrix run 37236762366 ran on
With the code reviews at |
The snapshot build failed when GitHub answered one download with HTTP 429 (run 37235545301, "Building Linux packages").
build-linux-packages.shfetched the LuCLI jar, and then the SQLite JDBC jar, with a barecurl -fsSL, so one rate-limited response ended the publish. The job's earlier nfpm fetch already retried.Changes:
tools/distribution-drafts/linux-packages/build-linux-packages.sh: the LuCLI jar and SQLite JDBC downloads get--retry 3 --retry-delay 2 --retry-all-errors, like the nfpm fetch. The SHA-256 checks that follow each download are unchanged..github/workflows/release-candidate.yml: the CommandBox GPG key download gets the same flags. Its-fsSlbecomes-fsSL: a lowercaselis--list-only, not "follow redirects"..github/workflows/compat-pr.yml,compat-matrix.yml: the Oracle JDBC driver (ojdbc10.jar) was fetched with a barewget -q. Oracle gates the matrix, so one rate-limited response turned a whole leg red. Both now usecurlwith the same retry flags.Checked and left alone:
release.yml's dispatch calls: they'rePOSTs whose status is checked, and a blind retry could fire a dispatch twice.tools/ci/*andsnapshot.ymlrequests: they go to the local test server, inside wait loops.Verification:
curlcommands, run as written against the real URLs, download the LuCLI 0.6.2.2 jar and sqlite-jdbc 3.49.1.0 with SHA-256 matching the pins (tools/lucli.jsonand the script). The GPG key comes down as a PGP public key block. The newojdbc10.jarfetch downloads the 4.5 MB jar containingoracle/jdbc/OracleDriver.class.bash -npasses on the script, and all three workflow files parse.🤖 Generated with Claude Code