Repository navigation
ci(release): make the Slack release text bump-agnostic and bound the webhook call - #4685
Merged
Merged
Conversation
…webhook call Follow-ups from r2's review of #4679 (both LOW): - The mrkdwn text hardcoded "patch release", mislabelling minor/major GAs. It is now bump-type agnostic: "*Wheels <version>* is released." plus a link to the GitHub release notes. - The curl call had no connect/overall timeouts, so a stalled webhook could delay the downstream homebrew/scoop and apt/yum dispatch steps. Add --connect-timeout 10 --max-time 20; the existing warning-and-exit-0 path still handles failures. - Guard the jq payload build the same way, so a payload-build failure warns and exits 0 instead of aborting the step. The main-only gate and the empty-secret skip are unchanged. Signed-off-by: Peter Amiri <peter@alurium.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from r2's review of #4679 (both LOW), ahead of the next GA. Gating and the empty-secret skip are unchanged and verified as before: the step still runs only for
refs/heads/mainafterCreate GitHub Releasesucceeded, so the snapshotworkflow_callnever posts.Bump-type agnostic text. The mrkdwn text hardcoded “patch release”, which would mislabel 4.3.0 or any minor/major GA. It is now:
{"text":"*Wheels 4.3.0* is released.\n<https://github.com/wheels-dev/wheels/releases/tag/v4.3.0|Release notes on GitHub>"}Bounded webhook call.
curlnow uses--connect-timeout 10 --max-time 20, so a stalled webhook cannot delay the downstreamDispatch downstream package managers/Dispatch Linux repo buckets/ bump-develop steps further down the job. The existing::warning::+exit 0path handles failures.Payload build guarded too. A
jqfailure now logs::warning::Could not build the Slack release payload; skipping notification.and exits 0, matching the delivery-failure behaviour.curlstill posts to$SLACK_WEBHOOK_URLwith-fsS; no webhook or secret value is in the repo..github/RELEASE_PLAYBOOK.mdalready describes the behaviour without the word “patch”, so it needed no edit.Validation
YAML OK.actionlint .github/workflows/release.yml→ exit 0; findings are byte-for-byte the same pre-existing shellcheck advisories asorigin/develop(2× SC2001, 5× SC2086, 2× SC2155 — none in the new step).runblock (Ruby YAML →/tmp/slack_step_followup.sh), with a fake secret token:no SLACK_WEBHOOK_URL — skipping release notification, exit 0;jq -e), message printed, secret not echoed (0 occurrences in output), exit 0;::warning::Slack release notification failed; the release itself is unaffected., exit 0 (fails immediately; the timeouts only bound a stalled connection).Refs #4679