feat: Show Crypto Services section (WPB-27920) - #5171
Conversation
…-info-screen # Conflicts: # app/src/main/kotlin/com/wire/android/di/metro/WireMetroViewModelBindings.kt # app/src/main/kotlin/com/wire/android/ui/debug/DebugInfoViewModelFactory.kt
yamilmedina
left a comment
yamilmedina
left a comment
There was a problem hiding this comment.
Small change needed for the naming of the section, overall good to go after we fix that 🚀
| } | ||
| } | ||
| _state.update { current -> current.copy(appPaths = appPathsProvider(), providers = providers) } | ||
| val appCryptoServices = withContext(dispatcherProvider.io()) { appCryptoServicesProvider() } |
There was a problem hiding this comment.
Question: I think this might/rarely throw an exception, perhaps catching the error would be nice to fallback to a "not-found" kind of mechanism
…into show-crypto-services # Conflicts: # app/src/main/kotlin/com/wire/android/ui/debug/securityproviders/SecurityProvidersViewModel.kt
# Conflicts: # app/src/main/kotlin/com/wire/android/ui/debug/securityproviders/AppPathsProvider.kt # app/src/main/kotlin/com/wire/android/ui/debug/securityproviders/SecurityProvidersScreen.kt # app/src/main/kotlin/com/wire/android/ui/debug/securityproviders/SecurityProvidersViewModel.kt # app/src/main/res/values/strings.xml # kalium
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #5171 +/- ##
===========================================
- Coverage 52.19% 52.08% -0.11%
===========================================
Files 668 671 +3
Lines 23972 24022 +50
Branches 3950 3952 +2
===========================================
Hits 12512 12512
- Misses 10300 10350 +50
Partials 1160 1160
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Test Results2 267 tests 2 267 ✅ 3m 5s ⏱️ Results for commit 25d65ad. ♻️ This comment has been updated with latest results. |
# Conflicts: # kalium
# Conflicts: # app/src/main/kotlin/com/wire/android/ui/debug/securityproviders/SecurityProvidersViewModel.kt
|
APKs built during tests are available here. Scroll down to Artifacts! |
# Conflicts: # app/src/main/kotlin/com/wire/android/di/accountScoped/DebugModule.kt # app/src/main/kotlin/com/wire/android/ui/debug/securityproviders/AppPathsProvider.kt # app/src/main/kotlin/com/wire/android/ui/debug/securityproviders/SecurityProvidersViewModel.kt
|
APKs built during tests are available here. Scroll down to Artifacts! |
2 participants
https://wearezeta.atlassian.net/browse/WPB-27920
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Adds a Crypto Services section to the debug screen showing which security provider serves each cryptographic call site on this device.
Screen_recording_20260813_115048.mp4
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.