feat(windows): add native MSI installer (WPB-5221) - #9722
Draft
adamlow-wire wants to merge 8 commits into
Draft
Conversation
| // Windows-specific stage: Update RELEASES file for Squirrel auto-updates | ||
| // ------------------------------------------------------------------------ | ||
| if (projectName.contains('Windows')) { | ||
| if (projectName.contains('Windows') && !isWindowsMsi) { |
Member
There was a problem hiding this comment.
isWindowsMsi is no longer defined (hasWindowsMsi and hasWindowsSquirrel are now used above) so this should fail when the Jenkins deployment reaches this stage. Since a build can now intentionally contain both installer families I think this should be based on hasWindowsSquirrel so we still update the Squirrel RELEASES feed whenever those artifacts are present.
|
|
||
| if (params.Release == 'Production') { | ||
| env.S3_PATH = 'win/prod' | ||
| env.MSI_S3_PATH = 'win/msi/prod' |
Member
There was a problem hiding this comment.
The MSI is uploaded to MSI_S3_PATH here, but the later Generate & Store Presigned URLs stage iterates all wrap/dist artifacts and always generates URLs using env.S3_PATH. That means the MSI URL will point to win/prod/... instead of win/msi/prod/...
Can we select the S3 path based on the artifact there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a native, per-machine Windows MSI installer for enterprise deployment through MDM and software-management systems.
The existing Squirrel EXE path remains available. MSI installations deliberately do not run the application-managed Squirrel updater; enterprises update them by deploying a newer MSI with the same permanent upgrade code.
Jira: WPB-5221
What changed
electron-builderMSI build target with stable product-family upgrade codesmsiexecdeploymentwire:protocol registrationUpdate.exeValidation
git diff --checkpassmsiexec /a ... /qnsucceedsRelease checks still required
Security