Skip to content

fix: address road pickup ETA review feedback - #48

Open
agrawalmilin9 wants to merge 1 commit into
wncc:mainfrom
agrawalmilin9:fix/road-pickup-eta-review
Open

agrawalmilin9 wants to merge 1 commit into
wncc:mainfrom
agrawalmilin9:fix/road-pickup-eta-review

Conversation

@agrawalmilin9

Copy link
Copy Markdown

Summary

Addresses review feedback from the road-based pickup ETA implementation.

Changes

  • Moved synchronous dispatch matching to asyncio.to_thread() to avoid blocking the event loop.
  • Added a bounded LRU cache for turn costs.
  • Protected shared turn-cache operations with a thread lock.
  • Added tests for LRU eviction and restricted-turn caching.
  • Added backend tests for RouteService initialization and road-based ETA estimation.
  • Removed the UTF-8 BOM from the benchmark script.

Testing

  • pytest tests backend/tests -q
  • 129 passed, 1 skipped, 16 subtests passed
  • git diff --check passed.

Related

Follow-up to PR #34 — Optimize road-based pickup ETA matching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants