fix unconditional SHA512 opt-in for wolfHSM builds - #836
Merged
aidangarske merged 1 commit intoJul 29, 2026
Merged
Conversation
…pe to only TZ mode
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts wolfBoot’s wolfHSM build configuration so SHA-384/SHA-512 are no longer force-enabled for all WOLFHSM_SERVER=1 builds, and instead are enabled only for the TrustZone wolfHSM secure-side engine (WOLFCRYPT_TZ_WOLFHSM) via include/user_settings.h.
Changes:
- Remove unconditional
sha512.olinkage from theWOLFHSM_SERVERbuild path inoptions.mk. - Gate
WOLFSSL_SHA384/WOLFSSL_SHA512opt-in underWOLFCRYPT_TZ_WOLFHSMininclude/user_settings.h.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| options.mk | Stops always linking SHA-512 for WOLFHSM_SERVER=1, relying on existing feature/hash-driven linkage where needed. |
| include/user_settings.h | Restricts SHA-384/SHA-512 opt-in to TrustZone wolfHSM builds, keeping verify-only wolfHSM server builds from enabling them by default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unconditional SHA348 and SHA512 opt-in for all wolfHSM server builds and relocates to TZ-specific user_settings.h block