Fix SHA2 benchmarks skipped in non-DMA builds - #497
Open
kojiws wants to merge 1 commit into
Open
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #497
No scan targets match the changed files in this PR. Review skipped.
kojiws
changed the title
kojiws
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs in
benchmark/bench_modules/wh_bench_mod_sha2.c:wh_Bench_Mod_Sha256/224/384/512returnedWH_ERROR_NOTIMPLand were silently-> SKIPPED._benchSha256returned directly whenwh_Bench_SetDataSizefailed, leaking theDMA-heap buffers.
Test
Fix 1: with
make(non-DMA), all four SHA2 results now appear; previously none did.Fix 2: verified by inspection/compilation only — triggering it needs a
wh_Bench_SetDataSizefailure, which was not fault-injected.