Implement SHA3 hash benchmarks (224/256/384/512) - #499
Open
kojiws wants to merge 1 commit into
Open
Conversation
kojiws
force-pushed
the
fix_sha3_benchmark
branch
from
July 29, 2026 06:48
e83f149 to
d7727b1
Compare
kojiws
changed the title
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #499
No scan targets match the changed files in this PR. Review skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables the SHA3 benchmarks in
benchmark/bench_modules/wh_bench_mod_sha3.c,which were stubs returning
WH_ERROR_NOTIMPLand silently-> SKIPPED.Covers all four variants (224/256/384/512), DMA and non-DMA. SHA3 entries
switched from
BENCH_THROUGHPUT_NONEtoXBPSso throughput is reported.HMAC-SHA3 is out of scope and stays
SKIPPED.Test
make DMA=1: all eight SHA3 rows report; previously two wereSKIPPEDandsix did not exist.
make(non-DMA): the four non-DMA rows report.