Fix expected failing value for WFSEEK() - #1145
Open
rlm2002 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds on to #1139. Adds
WFSEEK_SUCCESS()towolfssh/port.h, fixes issue where checking the return value ofWFSEEK()against 0 may fail erroneously due to Nucleus (NU_Seek()) and MPLAB Harmony (SYS_FS_FileSeek()) returning the new file position and only signaling failure with a negative value.Switches four call sites that test the
WFSEEK()result:src/ssh.c:wolfSSH_ReadKey_file()src/wolfsftp.c: resume seek inwolfSSH_SFTP_Put()apps/wolfssh/common.c,examples/client/common.c:load_der_file()