rtl8735b: add plaintext-key AES-GCM device test alongside HUK, selected by devId - #612
Open
dgarske wants to merge 2 commits into
Open
rtl8735b: add plaintext-key AES-GCM device test alongside HUK, selected by devId#612dgarske wants to merge 2 commits into
dgarske wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an optional second crypto-callback device for RTL8735B that exercises AES-GCM using a plaintext caller-supplied key (selected by devId) alongside the existing HUK-bound device, and documents/controls it via build settings.
Changes:
- Enable
WOLFSSL_RTL8735B_AESin the RTL8735B example settings to compile plaintext-key AES tests. - Add an AES-GCM known-answer test (published vector) plus a “coexistence” demonstration comparing ciphertext across the plaintext device vs HUK device.
- Document the new second-device behavior and selection mechanism (
devId) in the RTL8735B README.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rtl8735b/user_settings.h | Enables the plaintext-key AES device build flag alongside the existing HUK setup. |
| rtl8735b/README.md | Documents the second crypto-callback device and how devId selects plaintext vs HUK behavior. |
| rtl8735b/main.c | Implements plaintext-key AES-GCM KAT + coexistence demo and registers/unregisters the second device. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the AmebaPro2 RTL8735B HUK example (
rtl8735b/) with a plaintext-key AES-GCM test that uses the newWOLFSSL_RTL8735B_AEScrypto-callback device, registered alongside the HUK device and selected perAesby devId. Companion to wolfSSL PR wolfSSL/wolfssl#10970 (required to build).What it adds
WOLFSSL_RTL8735B_AESinuser_settings.hand registerswc_Rtl8735b_AesRegister(WC_RTL8735B_AES_DEVID)next towc_Rtl8735b_HukRegister(WC_HUK_DEVID).Testing
On the RealTek RTL8735B (AmebaPro2 EVB): 67/67 PASS, including the plaintext AES-GCM vector match and HUK coexistence.
wolfSSL/wolfssl#10970