Regression testing fixes - #11001
Open
SparkiDev wants to merge 1 commit into
Open
Conversation
wc_mlkem.h/test_mlkem.c: Respect WC_NO_CONSTRUCTORS guard. settings.h, fe_operations.h: move WOLFSSL_CURVE25519_USE_ED25519 derivation into settings.h so the assembler sees it; fixes fe_cmov_table undefined on ARM32. ge_448.c: shift the product instead of the byte in six sc448_* loops, dodging a GCC ARM32 NEON miscompile that produced wrong ed448 signatures; table shrunk [56]→[28].
Contributor
Author
|
Jenkins: retest this please |
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11001
Scan targets checked: wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wc_mlkem.h/test_mlkem.c: Respect WC_NO_CONSTRUCTORS guard.
settings.h, fe_operations.h: move WOLFSSL_CURVE25519_USE_ED25519 derivation into settings.h so the assembler sees it; fixes fe_cmov_table undefined on ARM32.
ge_448.c: shift the product instead of the byte in six sc448_* loops, dodging a GCC ARM32 NEON miscompile that produced wrong ed448 signatures; table shrunk [56]→[28].
Testing
./configure --disable-shared --disable-rsa --disable-dh --disable-dsa --enable-ecc --disable-curve448 --disable-ed448 --enable-opensslall --disable-asm --disable-sp-asm --enable-curve25519 --enable-ed25519 CFLAGS=-DWC_NO_CONSTRUCTORS
./configure --disable-shared --disable-rsa --disable-dh --disable-dsa --enable-ecc --disable-curve448 --disable-ed448 --enable-opensslall --host=armv8 CC=arm-linux-gnueabihf-gcc LDFLAGS=--static --enable-armasm --enable-curve25519 --enable-ed25519 "CFLAGS=-DNO_ED25519_MAKE_KEY -DNO_ED25519_SIGN"
./configure --disable-shared --disable-rsa --disable-dh --disable-dsa --enable-ecc --disable-curve25519 --disable-ed25519 --enable-opensslall --host=armv8 CC=arm-linux-gnueabihf-gcc LDFLAGS=--static --enable-armasm --enable-curve448=small --enable-ed448=small