Skip to content

Remove dead .eot font references for star and WooCommerce icon fonts - #2221

Merged
gigitux merged 1 commit into
woocommerce:trunkfrom
Arslan-TR:fix/remove-dead-eot-font-refs
Sep 18, 2026
Merged

gigitux merged 1 commit into
woocommerce:trunkfrom
Arslan-TR:fix/remove-dead-eot-font-refs

Conversation

@Arslan-TR

Copy link
Copy Markdown
Contributor

What

WooCommerce removed star.eot and WooCommerce.eot in woocommerce/woocommerce#31670. Storefront still registers @font-face rules pointing at those files, so every page load produces 404s for them (reported here).

Fix

Drop the .eot src entries from both @font-face blocks in add_core_fonts(). The woff/ttf/svg fallbacks already cover current browsers, so nothing regresses.

Fixes #2176

WooCommerce removed star.eot and WooCommerce.eot in
woocommerce/woocommerce#31670, so the src URLs registered here
404 on every page load. woff/ttf/svg formats already cover the
same browser range, so the .eot fallback is dropped.

Fixes woocommerce#2176
@Arslan-TR
Arslan-TR requested a review from a team as a code owner September 15, 2026 08:44
@Arslan-TR
Arslan-TR requested review from gigitux and removed request for a team September 15, 2026 08:44

@gigitux gigitux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to reproduce the 404 error mostly because modern browsers generally skip EOT and load WOFF, but this is a good refactor. LGTM

@gigitux
gigitux merged commit 76fb1ed into woocommerce:trunk Sep 18, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

star.eot and woocommerce.eot fonts don't exist anymore

2 participants