Repository navigation
Remove dead .eot font references for star and WooCommerce icon fonts - #2221
Merged
gigitux merged 1 commit intoSep 18, 2026
Merged
Conversation
WooCommerce removed star.eot and WooCommerce.eot in woocommerce/woocommerce#31670, so the src URLs registered here 404 on every page load. woff/ttf/svg formats already cover the same browser range, so the .eot fallback is dropped. Fixes woocommerce#2176
gigitux
approved these changes
Sep 18, 2026
gigitux
left a comment
Contributor
There was a problem hiding this comment.
I'm not able to reproduce the 404 error mostly because modern browsers generally skip EOT and load WOFF, but this is a good refactor. LGTM
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
WooCommerce removed
star.eotandWooCommerce.eotin woocommerce/woocommerce#31670. Storefront still registers@font-facerules pointing at those files, so every page load produces 404s for them (reported here).Fix
Drop the
.eotsrcentries from both@font-faceblocks inadd_core_fonts(). Thewoff/ttf/svgfallbacks already cover current browsers, so nothing regresses.Fixes #2176