Skip to content

Adjust multisite network cron Behat expectation for new WordPress privacy cleanup event#146

Merged
swissspidy merged 2 commits into
mainfrom
copilot/fix-tests-wordpress-7-1
Jul 9, 2026
Merged

Adjust multisite network cron Behat expectation for new WordPress privacy cleanup event#146
swissspidy merged 2 commits into
mainfrom
copilot/fix-tests-wordpress-7-1

Conversation

Copilot AI commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

WordPress 7.1 adds a scheduled wp_privacy_personal_data_cleanup_requests cron event, which increases events executed in the multisite --network --due-now Behat scenario. This caused the scenario to fail because the test’s exclusion list no longer matched current core behavior.

  • Problem alignment

    • Updated the multisite network cron run scenario in features/cron-event.feature to exclude the new core privacy cleanup hook alongside existing excluded core hooks.
  • Targeted test fixture change

    • Modified only the --exclude= list in the affected scenario (Run cron events with --network flag on multisite).
    • No runtime command implementation changes; this is a test expectation update to track WordPress core cron defaults.
  • Patch excerpt

    When I run `wp cron event run --due-now --network --exclude=wp_privacy_delete_old_export_files,wp_privacy_personal_data_cleanup_requests,wp_version_check,wp_update_plugins,wp_update_themes,wp_site_health_scheduled_check,wp_update_user_counts,wp_scheduled_delete,wp_scheduled_auto_draft_delete`

…cenario

Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix tests for WordPress 7.1 Adjust multisite network cron Behat expectation for new WordPress privacy cleanup event Jul 9, 2026
Copilot AI requested a review from swissspidy July 9, 2026 08:43
@swissspidy swissspidy added this to the 2.3.10 milestone Jul 9, 2026
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy marked this pull request as ready for review July 9, 2026 09:10
@swissspidy swissspidy requested a review from a team as a code owner July 9, 2026 09:10
Copilot AI review requested due to automatic review settings July 9, 2026 09:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Behat acceptance test for multisite wp cron event run --due-now --network to stay aligned with WordPress core’s default scheduled events by excluding the newly-added privacy cleanup hook, preventing the scenario from counting an extra executed event.

Changes:

  • Extend the multisite --network --due-now scenario’s --exclude= list to include wp_privacy_personal_data_cleanup_requests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@swissspidy swissspidy merged commit 7fa5fea into main Jul 9, 2026
63 checks passed
@swissspidy swissspidy deleted the copilot/fix-tests-wordpress-7-1 branch July 9, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix tests for WordPress 7.1

3 participants