Repository navigation
Player Move/Teleport buttons in the Information header instead of a popup - #187
Conversation
Instead of a popup floating over the selected hex, a player's move controls sit in the Information panel between the hex number and the terrain. The selected hex is the destination; either button only declares intent and the DM still approves. The popup component is gone. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0bd7c16835
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <div> | ||
| <div className="flex items-baseline justify-between mb-3"> | ||
| <h2 className="font-semibold text-ink-100"> | ||
| <div className="flex items-center justify-between gap-2 mb-3"> |
There was a problem hiding this comment.
When the desktop panel is resized toward its supported 240px minimum, or when a player uses a larger UI scale, the two shrink-0 labels plus the default-verbose Move/Teleport buttons cannot fit on this non-wrapping flex row. The buttons and terrain label then overlap or extend beyond the sidebar; a pending request adds another label and makes this occur at common phone widths as well. Allow this header to wrap or put the actions on a separate responsive row.
Useful? React with 👍 / 👎.
| Hex {hex.q}, {hex.r} | ||
| </h2> | ||
| <span className="text-xs text-ink-400"> | ||
| {!isDm && <PlayerMoveButtons hex={hex} characterId={viewingAs?.characterId ?? myCharacterId} />} |
There was a problem hiding this comment.
If a player has scrolled the Information panel down and then selects another destination on the desktop map, the existing .panel-scroll element retains its scroll position while InspectTab rerenders. Because the movement controls now exist only at the top of that scrolling body, the newly selected destination appears to have no Move/Teleport actions until the player manually scrolls back to the top; the removed map popup did not depend on sidebar scroll position. Make this header sticky or reset the Information panel scroll position when the selected hex changes.
Useful? React with 👍 / 👎.
Players no longer get a popup over the clicked hex. The Move and ⚡ Teleport buttons sit in the Information panel header between the hex number and the terrain; the selected hex is the destination and both still go through DM approval (an "awaiting DM" hint shows while a request is pending).
PlayerHexActionsis removed. Also shown in the DM's view-as-player preview.🤖 Generated with Claude Code