Repository navigation
fix: support Nginx Basic Auth for Agent Commons admin without second login - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce optional
MCP_AGENT_COMMONS_ADMIN_AUTH_MODE=nginx_basic. Nginx protects/agent-commons/adminand/agent-commons/admin/api/*; the backend independently verifies the Authorization header against a configured password SHA-256 and username, including direct local requests. The browser skips the extra internal login. Default session-login mode remains unchanged. Not enabled in production. Requires testing before merging and requires Nginx Basic Auth setup and matching password hash in service environment.