Skip to content

cache: use mockMetrics instead of the no-op implementation - #4239

Merged
MustafaSaber merged 1 commit into
masterfrom
use-mockmetrics
Sep 3, 2026
Merged

MustafaSaber merged 1 commit into
masterfrom
use-mockmetrics

Conversation

@MustafaSaber

Copy link
Copy Markdown
Collaborator

see subject

follow up on #4033

@MustafaSaber MustafaSaber added the minor no risk changes, for example new filters label Sep 2, 2026
@zalando-robot

Copy link
Copy Markdown

Docker image "registry-write.opensource.zalan.do/teapot/skipper:dc288ed4131212d55427db57826cfeaf390a25c6" is not based on an approved base image. Any production deployment relying on this image will be blocked.

To create a compliant Docker image of your application, you must reference an allowed Docker image as its base image in your Dockerfile. This base image must come from the Zalando Container Registry namespace library and use a recommended version as listed in the documentation.

@MustafaSaber
MustafaSaber force-pushed the use-mockmetrics branch 2 times, most recently from b77c4dc to d521d08 Compare September 2, 2026 12:20
MustafaSaber added a commit that referenced this pull request Sep 2, 2026
We did the init inside synctest but made the cleanup in the creation
function with `t.Cleanup` which was trying to close routines at the end
of the test function (e.g. after synctest) and try to close channels
created inside synctest which already finished which cause the panic

see #4239

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
@zalando-robot

Copy link
Copy Markdown

Docker image "registry-write.opensource.zalan.do/teapot/skipper:46308950919f68664435bd20c0698c47d899a5c9" is not based on an approved base image. Any production deployment relying on this image will be blocked.

To create a compliant Docker image of your application, you must reference an allowed Docker image as its base image in your Dockerfile. This base image must come from the Zalando Container Registry namespace library and use a recommended version as listed in the documentation.

@MustafaSaber

Copy link
Copy Markdown
Collaborator Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor no risk changes, for example new filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants