Maintenance: check translated languages in CI. - #1323
Merged
Merged
Conversation
suelje
marked this pull request as ready for review
September 25, 2026 13:19
ralf401
approved these changes
Sep 25, 2026
ralf401
left a comment
Contributor
There was a problem hiding this comment.
Nice! To have CI green, we have to fix the one Italian string by overwriting it hard, because this is no Weblate PR, right?
Member
Author
|
I fixed the Italian string and would now simply wait for the change to be merged. Then afterwards, this CI will become green and we can merge it on top, right? |
Contributor
|
Yeah makes sense. I'll merge the other Weblate translation PRs now. |
suelje
force-pushed
the
check-translations
branch
from
September 28, 2026 06:46
20bfa32 to
1347446
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI: check translated languages
Why
The shared documentation workflow builds English only. A translation that breaks the markup of its source string, for example a translated
:doc:target, passes CI and only shows up after the Weblate PR is merged, as a broken link or raw markup on the rendered page. Read the Docs builds the translated languages but reports success regardless of warnings, so the breakage stays silent. See coordination-scrum #1756.What
test.ymlopts in to the newcheck_translationsinput of the shared workflow (zammad/zammad-documentation, see the corresponding PR there). The workflow then buildsde,it,pt_BRandsr, the languages published on Read the Docs, with warnings treated as errors and lists the broken strings at the end of the job:Each line is also reported as an error annotation. A Weblate PR with a broken translation fails before merge instead of after deployment. Nothing else changes; English is still built as before.
Depends on
zammad/zammad-documentation PR "CI: check translated languages and fail on warnings". It has to be merged to
pre-releasefirst, otherwise thecheck_translationsinput is unknown and the workflow call fails.Verified
Tested against a fork pointing at the fork's copy of the shared workflow:
de,pt_BRandsrpass,itfails with the one string above, the job ends with the list shown.