Repository navigation
Feat/read write direct #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
normanrz
merged 6 commits into
zarr-developers:main
from
konstibob:feat/read_write_direct
Nov 4, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7f158fb
add direct array read / Write
konstibob 7173f31
readInnerChunksdirect now works
konstibob 10d1091
Clarify innerChunkShape docs for nested shards
konstibob a85e947
adjusted writing mechanism
konstibob de4799d
Merge main into feat/read_write_direct
konstibob 0760605
Address review: shard-scoped InnerChunkWriter and level-based inner c…
konstibob File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels out-of-place. Array doesn't even have a "chunkShape" getter, so why would it have an "innerChunkShape" getter. I wonder if, instead, we should have a few new classes that represent the "chunking" of an array, e.g. "RegularChunking", "ShardedRegularChunking", "RectilinearChunking" (future). Depending on the type the user code can then work with the chunking. As a companion there could also be classes that address chunks, which would replace the
long[] chunkCoords(andlong[][] innerChunkCoords).