Repository navigation
Implement #16 (CI + parser fix), #15 (config Extends), #26 (faker inputs) - #40
Merged
Merged
Conversation
…browser jobs Resolves #16. A bare action keyword (e.g. `Fill` with no selector/args) was accepted by the grammar because all operands are optional. Add post-parse validation requiring at least one operand for every action except the navigation-only GoBack/GoForward/Refresh, fixing the failing TestParseFail. Rework .github/workflows/ci.yaml: checkout before setup-go, Go 1.24 (matching go.mod), module cache, a required build+vet+test job, and a non-blocking browser-tests job with Playwright browser caching. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Implements #15. A spec's frontmatter can extend another file: Extends : "./base.basi;Browser,Headless" Adds the `Extends` lexer token and ResolveExtends, which resolves the referenced path relative to the current file, inherits all declared fields (or only the named sections after `;`), merges with local-wins semantics, resolves parent chains recursively, and detects circular references. Wired into `basi run` so inherited fields are visible before the executor is built. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Implements #26. Action string arguments may use faker tokens, e.g. Fill "input[name=email]" "{{faker.email}}" Adds gofakeit-backed interpolation for 21 faker types and wires variable and faker interpolation into the main action-dispatch path (previously only the property-testing path interpolated), so `$var` substitution now also works for normal actions. A `FakerSeed` frontmatter key makes output deterministic; values regenerate per repeated run. Also updates basi-issues-spec.md to reflect implemented/pending status. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements three issues from
basi-issues-spec.md, as three per-issue commits. Each commit builds independently.#16 — CI pipeline + parser fix (
e47ba70)Fillwith no selector/args) was wrongly accepted because all operands are optional in the grammar. Added post-parse validation requiring at least one operand for every action except the navigation-onlyGoBack/GoForward/Refresh. Fixes the pre-existing failingTestParseFail..github/workflows/ci.yaml— checkout beforesetup-go, Go 1.24 (matchinggo.mod), module cache, a requiredbuild + vet + testjob, and a non-blockingbrowser-testsjob with Playwright browser caching.#15 — Inherit frontmatter via
Extends(387c367)A spec can extend another
.basifile's frontmatter:;.basi runso inherited fields are visible before the executor is built.extends_test.go).#26 — Faker values in action arguments (
bc1954d)email,name,uuid,phone, …); unknown tokens are left unchanged.$var+ faker interpolation into the main action-dispatch path — previously only the property-testing path interpolated, so$varsubstitution now works for normal actions likeFilltoo.FakerSeedfrontmatter key for deterministic output; values regenerate per repeated run.playwright/faker_test.go).Verification
go build ./...,go vet -structtag=false -composites=false ./..., andgo test ./ ./core/... ./playwright/...all green.go mod verify→ all modules verified (addsgithub.com/brianvoe/gofakeit/v6 v6.28.0).Closes #16, closes #15, closes #26.
🤖 Generated with Claude Code