Respect .gitignore negation patterns during indexing#399
Open
caioribeiroclw-pixel wants to merge 1 commit into
Open
Respect .gitignore negation patterns during indexing#399caioribeiroclw-pixel wants to merge 1 commit into
caioribeiroclw-pixel wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #397.
This makes file-based ignore matching honor
!negation patterns instead of treating them as inert literal patterns. The bug in #397 can silently remove intentionally tracked/whitelisted directories from the index, which is especially risky for code-search agents because the user sees a completed index but the search universe is incomplete.What changed:
Context.matchesIgnorePatternnow evaluates ignore rules in order and lets later!patternrules re-include matching paths.FileSynchronizer.shouldIgnoreuses the same ordered negation behavior so initial indexing and sync hashing stay aligned.Validation:
git diff --checkpackages/core:./node_modules/.bin/jest src/context.ignore-patterns.test.ts --runInBandpackages/core:./node_modules/.bin/tsc --noEmitNote: I intentionally kept this narrow and did not replace the matcher with a full gitignore parser. The goal is to fix the silent exclusion case from #397 without changing unrelated ignore semantics.