Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On macOS, Meru builds new-email notifications with
silent: trueand plays its own.wavfrom the renderer on the notification'sshowevent.showfires even while Do Not Disturb or a Focus is suppressing the notification, so the sound plays through it, for example overnight. Every free user is affected, since an unlicensed copy always plays Linen.Handing a bundled sound to macOS (#1102) was tried and closed. Measured on 20 Oct 2026 on macOS 27: NotificationCenter caches each app bundle's
Contents/Resourceslisting. After an in-place update it plays the default alert for every bundled name, or nothing, until NotificationCenter restarts. Built-in sounds in/System/Library/Soundsalways resolve, and Do Not Disturb silences a sound carried by the notification whatever its source.Change
On macOS only:
sound: "Blow",silent: false), and nothing is played onshow.>=3.35.0step's accepted list gains the macOS names, because the ladder reruns on a fresh install's second launch and would otherwise reset a picked macOS sound to Linen./usr/bin/afplayin the main process (new IPC channelnotifications.previewSound). The name is checked against the 14 known names.setImmediate. After that, the 5 s sliding rule applies as before.Windows and Linux are unchanged: bundled sounds played by the renderer, and #1200's rule.
Proof
Signed arm64 builds (
op run --env-file .env.signing.op -- bun run build:mac:dmg), unlicensed, fresh profile. A script counts rendererHTMLMediaElement.prototype.playcalls and sends fivenotifications.showTestNotificationback to back. Do Not Disturb is toggled with a Shortcut, and NotificationCenter and donotdisturbd logs are captured.Before (
main), Do Not Disturb on. The banners are suppressed, but Meru plays the sound anyway:After (this branch), Do Not Disturb on:
After, Do Not Disturb off, five at once:
The Do Not Disturb-on run and the spaced runs were measured on the first commit, with Glass as the default: five notifications 1 s apart gave one sound, with the other four
hasSound: false, and two 6 s apart gave two. The five-at-once Do Not Disturb-off run above is from the Blow commit.bun run fmt:check,lint,typesandbun test --isolate(1554 pass) are green.Risk
Revert the commit to restore the bundled sounds on macOS. Stored macOS names then fall back through the renderer path as Linen.
Not verified