fix: classify large modifications as feat instead of fix - #1
Merged
Conversation
A 1-line typo fix and a 200+ line rewrite were both landing on 'fix:' because inferType() only looked at file status (A/M/D), never diff size. Modified files whose total changed lines (additions + deletions) reach largeChangeThreshold (50) now classify as feat. Found via dogfooding on a real 224-line change (src/app.py in ai-research-summarizer) that was incorrectly labeled fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Modified files whose total changed lines (additions + deletions) reach
50+ now classify as
featinstead offix.Why
A 1-line typo fix and a 200+ line rewrite were both landing on
fix:because
inferType()only looked at file status (A/M/D), never diffsize.
How I found this
Dogfooded commitcraft on a real project (a 224-line change to
src/app.py) and noticed it labeled a substantial rewrite asfix.Testing
Added 4 new test cases covering: small diff stays fix, large diff
becomes feat, and the boundary right at/under the threshold.
All 12 tests pass.