Repository navigation
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a removal regression test to the branch behind omacom/omarchy#12264.
Dockurr's sharing service can set
/sharedto mode2777. On currentquattro,prepare_caller_mountsrunschmod 0700, which leaves the setgid bit in place. The subsequent exact-mode check sees2700, so removal stops before deleting the VM disk.The test sets the shared directory to
2777, runsprepare_caller_mounts, and calls__priv_remove. It checks that removal deletes the disk data, keeps the shared files, and leaves the shared directory at700. The namespace test callsprepare_caller_mountsexplicitly because the production removal path calls it through privilegedassert_mounts_safe.With this test added,
windows-vm-compose-test.shexits 1 on untouchedquattroatprepare_caller_mountsand passes on the head of omacom#12264.windows-vm-launcher-test.sh,windows-vm-test.sh, andgit diff --checkpass too.I also reproduced the error on Omarchy 4.0.4-1 after a successful
omarchy-windows-vm install. The Windows ISO download was still retrying, so I applied thechmod 2777 /sharedoperation from Dockurr's running/run/samba.shinside the container.omarchy-windows-vm removethen failed with the reported message and left the VM data intact. Clearing setgid let the same removal command succeed.I ran
./test/all. The changed compose test passed, but the aggregate suite exited 1 with 14 failing test files. Several tests wrote directly to this host's quota-limited/tmp; others require local packages or services. The failures include the existingwindows-vm-mount-boundary-test.sh.