Skip to content

Test Windows VM removal with setgid shared directory #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexR1712 wants to merge 1 commit into
base: fold/windows-vm-marker-setgid
Choose a base branch
from
Open

Test Windows VM removal with setgid shared directory #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions test/shell.d/windows-vm-compose-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,10 +447,17 @@ umount -- "$EXPECTED_STORAGE"
dc() { return 1; }
__priv_remove 2>/dev/null && fail "removal deleted data after docker-compose down failed"
[[ -f $HOME/.windows/disk.img && -f $HOME/Windows/keep.txt && -f $COMPOSE ]] || fail "failed down changed data or compose"
# Dockur can leave the shared bind source setgid. Removal must harden it before
# validating the anchor, or the VM disk remains in place with a generic error.
chmod 2777 "$HOME/Windows"
# The privileged production path calls this from assert_mounts_safe; this
# namespace runs the same helper without root privileges.
prepare_caller_mounts
dc() { :; }
__priv_remove
[[ ! -e $HOME/.windows/disk.img ]] || fail "removal preserved disk data"
[[ -e $HOME/Windows/keep.txt ]] || fail "removal deleted shared data"
[[ $(stat -c '%a' "$HOME/Windows") == 700 ]] || fail "removal left the shared directory setgid"
[[ ! -f $COMPOSE ]] || fail "removal left compose"
resolve_caller
[[ $(mount_layer_count "$EXPECTED_STORAGE") == 0 && $(mount_layer_count "$EXPECTED_SHARED") == 0 ]] || fail "removal left binds"
Expand Down