Skip to content

test(sampling): unflake unsupported char tests - #20097

Open
KowalskiThomas wants to merge 1 commit into
mainfrom
dd/kowalski/fix-flaky-unsupported-char-sampling-test
Open

test(sampling): unflake unsupported char tests#20097
KowalskiThomas wants to merge 1 commit into
mainfrom
dd/kowalski/fix-flaky-unsupported-char-sampling-test

Conversation

@KowalskiThomas

@KowalskiThomas KowalskiThomas commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Description

https://datadoghq.atlassian.net/browse/PROF-15927

test_rule_init_via_env_service_pattern_contains_unsupported_char was flaky. This fixes the issue by forcing _raise=True inside each test's own override_global_config(...) so the assertion's precondition is guaranteed regardless of test ordering or ambient global state.

Co-authored-by: KowalskiThomas <14239160+KowalskiThomas@users.noreply.github.com>
@datadog-datadog-prod-us1

Copy link
Copy Markdown
Contributor

View session in Datadog

Bits Code status: ✅ Done

CI Auto-fix: Disabled | Enable

Comment @DataDog to request changes

@datadog-datadog-prod-us1

Copy link
Copy Markdown
Contributor

I can only run on private repositories.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

tests/tracer/test_single_span_sampling_rules.py                         @DataDog/apm-sdk-capabilities-python

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Pipelines  Tests

⚠️ Warnings

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 2 Pipeline jobs failed

Changelog | Validate changelog

View more details · View in GitHub Actions

Release note not found during changelog validation.

DataDog/apm-reliability/dd-trace-py | download_dependency_wheels: [3.15.0rc1, 3.15]

View more details · View in GitLab

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c182b98 | Docs | View more details | Give us feedback!

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 230 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 230 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=134)
ddtrace.debugging._signal.tracing -×-> ddtrace.trace  (product:debugging -> product:tracing, score=132)
ddtrace.appsec._listeners -×-> ddtrace.trace  (product:appsec -> product:tracing, score=132)
ddtrace.llmobs._integrations.openai -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=132)
ddtrace.profiling.scheduler -×-> ddtrace.trace  (product:profiling -> product:tracing, score=132)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@KowalskiThomas KowalskiThomas added changelog/no-changelog A changelog entry is not required for this PR. Tracing Distributed Tracing labels Sep 6, 2026
@KowalskiThomas
KowalskiThomas marked this pull request as ready for review September 7, 2026 07:56
@KowalskiThomas
KowalskiThomas requested a review from a team as a code owner September 7, 2026 07:56
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T07:58:55.749363Z c182b98 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bits AI changelog/no-changelog A changelog entry is not required for this PR. Tracing Distributed Tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants