Skip to content

test(sampling): unflake unsupported char tests #20097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KowalskiThomas wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

test(sampling): unflake unsupported char tests #20097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/tracer/test_single_span_sampling_rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,15 @@ def test_rule_init_via_env_no_name_or_service_logs_warning_and_continues(


def test_rule_init_via_env_service_pattern_contains_unsupported_char():
with override_global_config(dict(_sampling_rules='[{"service":"h[!a]i"}]')):
# Unsupported glob chars are only rejected when config._raise is True (testing mode). _raise is
# a process-global bridged to the native config, and other tests in the same worker can flip it,
# so force it here to keep this test order-independent instead of relying on the ambient value.
with override_global_config(dict(_sampling_rules='[{"service":"h[!a]i"}]', _raise=True)):
assert get_span_sampling_rules() == []


def test_rule_init_via_env_name_pattern_contains_unsupported_char():
with override_global_config(dict(_sampling_rules='[{"name":"h[!a]i"}]')):
with override_global_config(dict(_sampling_rules='[{"name":"h[!a]i"}]', _raise=True)):
assert get_span_sampling_rules() == []


Expand Down
Loading