Repository navigation
feat: replace nr-otel-collector with nrdot-collector - #92
Open
DavSanchez wants to merge 2 commits into
Open
DavSanchez wants to merge 2 commits into
DavSanchez wants to merge 2 commits into
Conversation
- Drop the deprecated nr-otel-collector package and its FOD source generation hack. - Drop the local ocb package (upstreamed in nixpkgs as opentelemetry-collector-builder) and build nrdot-collector with it. - Drop the local infrastructure-agent package (already in nixpkgs). - Add a fresh nrdot-collector package built from the New Relic nrdot-collector-releases repository. - Rename the darwin nr-otel-collector module to nrdot-collector and add a matching NixOS module.
ocb regenerates the distribution sources and runs 'go mod tidy' internally, which needs network access to proxy.golang.org. Only fixed-output derivations get network in Nix's sandbox, so running ocb inside buildGoModule's main build failed on Linux builders (the sandbox blocks network there; it only worked on macOS because its sandbox allows it). Commit the generated, self-contained Go module (a few files: main.go, components.go, go.mod, go.sum) and build from it directly, so the build is reproducible and network-free on every platform.
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the OpenTelemetry story. Fixes the core of the abandoned #10 and #13 (superseded).
nr-otel-collectorpackage and its FOD source-generation hack.ocbpackage (now upstreamed in nixpkgs asopentelemetry-collector-builder).infrastructure-agentpackage (also upstreamed in nixpkgs).nrdot-collectorpackage (New Relic's current OTel distribution, 2.0.0).go mod tidy(needs network), which Nix's sandbox only allows for fixed-output derivations. Committing the generated, self-contained Go module makes the build reproducible and network-free on every platform (macOS sandboxes allow network, Linux ones don't).nr-otel-collectormodule tonrdot-collectorand add a matching NixOS module.This is PR 2 of 4 in a stacked series (base: #91). Do not merge out of order.