Skip to content

Revert "feat: ExampleSponsoredDataSet" - #599

Merged
Kubuxu merged 1 commit into
mainfrom
revert-540-feat/sponsored-data-set
Aug 27, 2026
Merged

Kubuxu merged 1 commit into
mainfrom
revert-540-feat/sponsored-data-set

Conversation

@Kubuxu

@Kubuxu Kubuxu commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Reverts #540

From CI, it looks like a bad merge. Also we are right in the middle of release and it affects ABIs which can increase confusion.

Copilot AI lite review requested due to automatic review settings August 26, 2026 19:59
@Kubuxu
Kubuxu requested a review from wjmelements as a code owner August 26, 2026 19:59
@FilOzzy FilOzzy added this to FOC Aug 26, 2026
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Aug 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the previously introduced ExampleSponsoredDataSet feature set, removing the associated contracts/tests and rolling back the related ABI surface-area changes in order to avoid release-time ABI churn and confusion.

Changes:

  • Remove ExampleSponsoredDataSet / ExampleSponsoredDataSetFactory contract implementation and its Foundry test.
  • Remove the hasBeenProvenRecently and getDataSetPayerAndRailId helpers from FWSS state libraries and the generated FilecoinWarmStorageServiceStateView contract, and update committed ABI JSONs accordingly.
  • Remove the solady submodule wiring and Foundry remapping that were only used by the reverted feature.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
service_contracts/test/ExampleSponsoredDataSet.t.sol Deletes the test suite introduced for the reverted example dataset feature.
service_contracts/src/lib/FilecoinWarmStorageServiceStateLibrary.sol Removes two public helper functions that were added to support the reverted example dataset flow.
service_contracts/src/lib/FilecoinWarmStorageServiceStateInternalLibrary.sol Removes the internal equivalents of the same reverted helper functions.
service_contracts/src/FilecoinWarmStorageServiceStateView.sol Removes view-contract passthroughs for the reverted helper functions (aligns on-chain ABI with revert).
service_contracts/src/ExampleSponsoredDataSet.sol Deletes the reverted example dataset and factory contracts.
service_contracts/foundry.toml Removes the solady remapping no longer needed after the revert.
service_contracts/abi/FilecoinWarmStorageServiceStateView.abi.json Removes ABI entries corresponding to the removed view functions.
service_contracts/abi/FilecoinWarmStorageServiceStateLibrary.abi.json Removes ABI entries corresponding to the removed library functions.
.gitmodules Removes the service_contracts/lib/solady submodule entry.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-project-automation github-project-automation Bot moved this from 📌 Triage to ✔️ Approved by reviewer in FOC Aug 26, 2026
@Kubuxu
Kubuxu merged commit c7ad4c5 into main Aug 27, 2026
8 checks passed
@Kubuxu
Kubuxu deleted the revert-540-feat/sponsored-data-set branch August 27, 2026 01:07
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Aug 27, 2026
Kubuxu pushed a commit that referenced this pull request Sep 16, 2026
* Revert "Revert "feat: ExampleSponsoredDataSet" (#599)"

This reverts commit c7ad4c5.

* fix: correct initialize params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

4 participants