Revert "feat: ExampleSponsoredDataSet" - #599
Merged
Merged
Conversation
This reverts commit f461290.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the previously introduced ExampleSponsoredDataSet feature set, removing the associated contracts/tests and rolling back the related ABI surface-area changes in order to avoid release-time ABI churn and confusion.
Changes:
- Remove
ExampleSponsoredDataSet/ExampleSponsoredDataSetFactorycontract implementation and its Foundry test. - Remove the
hasBeenProvenRecentlyandgetDataSetPayerAndRailIdhelpers from FWSS state libraries and the generatedFilecoinWarmStorageServiceStateViewcontract, and update committed ABI JSONs accordingly. - Remove the
soladysubmodule wiring and Foundry remapping that were only used by the reverted feature.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| service_contracts/test/ExampleSponsoredDataSet.t.sol | Deletes the test suite introduced for the reverted example dataset feature. |
| service_contracts/src/lib/FilecoinWarmStorageServiceStateLibrary.sol | Removes two public helper functions that were added to support the reverted example dataset flow. |
| service_contracts/src/lib/FilecoinWarmStorageServiceStateInternalLibrary.sol | Removes the internal equivalents of the same reverted helper functions. |
| service_contracts/src/FilecoinWarmStorageServiceStateView.sol | Removes view-contract passthroughs for the reverted helper functions (aligns on-chain ABI with revert). |
| service_contracts/src/ExampleSponsoredDataSet.sol | Deletes the reverted example dataset and factory contracts. |
| service_contracts/foundry.toml | Removes the solady remapping no longer needed after the revert. |
| service_contracts/abi/FilecoinWarmStorageServiceStateView.abi.json | Removes ABI entries corresponding to the removed view functions. |
| service_contracts/abi/FilecoinWarmStorageServiceStateLibrary.abi.json | Removes ABI entries corresponding to the removed library functions. |
| .gitmodules | Removes the service_contracts/lib/solady submodule entry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rvagg
approved these changes
Aug 26, 2026
Kubuxu
pushed a commit
that referenced
this pull request
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #540
From CI, it looks like a bad merge. Also we are right in the middle of release and it affects ABIs which can increase confusion.