Repository navigation
fix(behat): retain escaped jq string assertions after removing legacy wrapper - #131
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
After v1.6.4 replaced
estahn/json-query-wrapper, the new JSON decoder unescaped the contents ofjqstring results. Existing Behat assertions compare against the previously preserved escaped representation, causing reproducible failures in LibreSignstable35(e.g.groups_request_sign_policy.feature).Changes
jqreturns a JSON string, while continuing native JSON decoding for objects, arrays, booleans and numbers.Validation
php -landgit diff --checkpass.Tracked from LibreSign/libresign#9324. No Behat 4 migration changes.